This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor(ngAnimateSwap): remove unused dependency and add tests #16565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -132,6 +132,51 @@ describe('ngAnimateSwap', function() { | |||
| expect(two).toBeTruthy(); | |||
| })); | |||
|
|
|||
| it('should create a new (non-isolate) scope for each inserted clone', inject(function() { | |||
There was a problem hiding this comment.
I'm not sure that this test proves that the new scopes are non-isolate?
There was a problem hiding this comment.
Wouldn't an isolate scope be directly derived from the rootScope and make this fail: expect(scopeOne.$parent).toBe(parentScope)
There was a problem hiding this comment.
No - an isolate scope still has a parent but it doesn't inherit from its parent. So
$parent.foo = 'bar';
$isoChild = $parent.$new(true);
assert($isoChild.foo !== 'bar');
assert($isoChild.$parent.foo === 'bar');
test/ngAnimate/ngAnimateSwapSpec.js
Outdated
| expect(scopeTwo.$$destroyed).toBe(true); | ||
| })); | ||
|
|
||
| it('should destroy the previous scope before when swapping elements', inject(function() { |
petebacondarwin
approved these changes
May 16, 2018
|
LGTM, but the |
…creating/removing scopes
gkalpak
force-pushed
the
refactor-ngAnimateSwap-unused-dep
branch
from
21f5b6c to
431dc5e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactor.
Tests.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Fix/Feature: Docs have been added/updated